bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects by isidentical · Pull Request #26677 · python/cpython
bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported ob…
bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Just two very minor issues.
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
I have made the requested changes; please review again
Thanks for making the requested changes!
@markshannon: please review the changes made to this pull request.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Sorry I missed your update, so importlib needs updating again.
Okay will regenerate them tomorrow.
🤖 New build scheduled with the buildbot fleet by @isidentical for commit ab1b6c1 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
| # Python 3.11a1 3455 (add MAKE_CELL bpo-43693) | ||
| # Python 3.11a1 3456 (interleave cell args bpo-43693) | ||
| # Python 3.11a1 3457 (Change localsplus to a bytes object bpo-43693) | ||
| # Python 3.11a1 3458 (imported objects now don't use LOAD_METHOD/CALL_METHOD) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the actual number be bumped below? I don't think it matters much in this case, but for the sake of consistency/clarity for the next bump, it might be good to fix.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, probably got away during rebase. Will fix