◐ Shell
clean mode source ↗

bpo-44297: Fix missing line number in generator expressions by markshannon · Pull Request #26801 · python/cpython

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gvanrossum

There seems to be an unrelated problem with test_logging; its test_race subtest looks flakey.

pablogsal

@miss-islington

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

Sorry, @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 82e5c28af7049c4f5343c808f172cbe2e145f49b 3.10

markshannon added a commit to markshannon/cpython that referenced this pull request

Jun 21, 2021
…-26801)

* Make sure that line number is set when entering comprehension scope in compiler.

(cherry picked from commit 82e5c28)

@pablogsal