bpo-42064: Remove stale extern declarations in `sqlite3` headers by erlend-aasland · Pull Request #26840 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
bpo-42064: Remove stale extern declarations in
bpo-42064: Remove stale extern declarations in sqlite3sqlite3 headers
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, we may need to update Tools/c-analyzer/cpython/ignored.tsv
See:
| Modules/_sqlite/connection.h - pysqlite_ConnectionType - |
IMHO, we may need to update
Tools/c-analyzer/cpython/ignored.tsv
I didn't know about this; thanks for the heads up! I'll update the PR. UPDATE: fixed in 285b341
Erlend E. Aasland added 2 commits
@corona10 I'll have an extra look at this later today; there's a lot more that can be removed from the c-analyzer ignore list.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm