bpo-42064: Move `sqlite3` exceptions to global state, part 2 of 2 by erlend-aasland · Pull Request #26884 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Conversation
FYI, for check_cursor and pysqlite_check_connection, we cannot rely on the connection context exception pointers (at least not for the early sanity checks), so I'm using the global state in those methods.
Erlend E. Aasland added 3 commits
(Re-opening to trigger CI again)
Erlend E. Aasland added 2 commits
- Use ADD_TYPE() - Naming: name => exc
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Looks good, thanks!
Thanks for reviewing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters