◐ Shell
clean mode source ↗

[3.10] bpo-44184: Apply GH-26274 to the non-GC-type branch of subtype_dealloc (GH-27165) by miss-islington · Pull Request #27174 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented

Jul 15, 2021

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

The non-GC-type branch of subtype_dealloc is using the type of an object after freeing in the same unsafe way as GH-26274 fixes. (I believe the old news entry covers this change well enough.)

https://bugs.python.org/issue44184
(cherry picked from commit 074e765)

Co-authored-by: T. Wouters thomas@python.org

https://bugs.python.org/issue44184

…dealloc (pythonGH-27165)

The non-GC-type branch of subtype_dealloc is using the type of an object after freeing in the same unsafe way as pythonGH-26274 fixes. (I believe the old news entry covers this change well enough.)

https://bugs.python.org/issue44184
(cherry picked from commit 074e765)

Co-authored-by: T. Wouters <thomas@python.org>

@miss-islington

Copy link Copy Markdown

Contributor Author

@Yhg1s: Status check is done, and it's a failure ❌ .

@Yhg1s

Yhg1s commented

Jul 15, 2021

Copy link Copy Markdown

Member

The failed Windows x86 test is test_unicodedata, and it failed because of network issues, nothing to do with the backport.

@Yhg1s Yhg1s merged commit 6aa59c6 into python:3.10

Jul 15, 2021

@miss-islington miss-islington deleted the backport-074e765-3.10 branch

July 15, 2021 23:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @Yhg1s @the-knights-who-say-ni @bedevere-bot