◐ Shell
clean mode source ↗

bpo-44991: Normalise `sqlite3` function and collation callback naming by erlend-aasland · Pull Request #28209 · python/cpython

@erlend-aasland

@erlend-aasland

@erlend-aasland erlend-aasland changed the title bpo-44991: Normalise function and collation callback naming bpo-44991: Normalise sqlite3 function and collation callback naming

Sep 7, 2021

@erlend-aasland

Reopening to trigger asan test again.

shihai1991

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping consistent code style is fine to me.

@erlend-aasland

Keeping consistent code style is fine to me.

Thanks for reviewing!

@github-actions

This PR is stale because it has been open for 30 days with no activity.

encukou

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care that strongly about the pysqlite prefix, so I didn't point this out in the earlier review.
But sure, let's make them consistent!