[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) by ambv · Pull Request #28217 · python/cpython
Comment on lines +413 to +416
| if not os.path.isdir(self.lib_dir): | ||
| # 3.0.0-beta2 uses lib64 on 64 bit platforms | ||
| lib64 = self.lib_dir + "64" | ||
| os.symlink(lib64, self.lib_dir) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this change causes all SSL tests to fail on 3.9?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems unlikely. The _post_install_300 function is only executed if self.version.startswith("3.0").
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have bisected the failing tests in 3.9. Tests are passing in commit for tag v3.9.7. Current 3.9 is failing. The issue was introduced in c967bd5 (GH-28153).
@serhiy-storchaka please take a look
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you didn't notice because the tests were skipped. Additional OpenSSL tests are only executed for some changes:
| git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qE '(ssl|hashlib|hmac|^.github)' && echo '::set-output name=run_ssl_tests::true' || true |