◐ Shell
clean mode source ↗

bpo-45212: Add a comment for time.sleep() in tests by serhiy-storchaka · Pull Request #28414 · python/cpython

serhiy-storchaka

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented

Sep 17, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. I just suggest to mention the bpo to ease future code reviews.
Comment thread

Lib/test/test_socket.py Outdated 

Co-authored-by: Victor Stinner <vstinner@python.org>

@serhiy-storchaka serhiy-storchaka merged commit 54a1760 into python:main

Sep 17, 2021

@serhiy-storchaka serhiy-storchaka deleted the test-socket-sleep-comment branch

September 17, 2021 13:20

@vstinner

Copy link Copy Markdown

Member

Thank you for adding the comment :-)

@serhiy-storchaka

Copy link Copy Markdown

Member Author

Thanks Łukasz.

niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request

Sep 21, 2021 
Co-authored-by: Victor Stinner <vstinner@python.org>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv approved these changes

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @vstinner @ambv @the-knights-who-say-ni @bedevere-bot