◐ Shell
clean mode source ↗

bpo-45471: Do not set _Py_path_config.stdlib_dir in Py_SetPythonHome(). by ericsnowcurrently · Pull Request #28954 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented

Oct 14, 2021

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

The change in gh-28586 (bpo-45211) should not have included code to set _Py_path_config.stdlib_dir in Py_SetPythonHome(). We fix that here.

https://bugs.python.org/issue45471

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 552f73e 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots

Test PR w/ buildbots; report in status section

label

Oct 14, 2021

@ericsnowcurrently ericsnowcurrently merged commit 0bbea07 into python:main

Oct 14, 2021

@ericsnowcurrently ericsnowcurrently deleted the config-stdlibdir-set-home branch

October 14, 2021 20:48

ericsnowcurrently added a commit that referenced this pull request

Oct 19, 2021
…uilds. (gh-29063)

In gh-28954 I adjusted how test_embed determines if it should be skipped. That broke out-of-tree builds. This change fixes them.

https://bugs.python.org/issue45506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsnowcurrently @bedevere-bot @the-knights-who-say-ni