◐ Shell
clean mode source ↗

bpo-45574: fix warning about `print_escape` being unused by sobolevn · Pull Request #29172 · python/cpython

sobolevn

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@sobolevn

@sobolevn sobolevn commented

Oct 22, 2021

•

edited by miss-islington

Loading

Copy link Copy Markdown

Member

It used to be like this:
Снимок экрана 2021-10-22 в 23 07 40

Quick grep tells that it is just used in one place under Py_DEBUG: https://github.com/python/cpython/blame/f6e8b80d20159596cf641305bad3a833bedd2f4f/Parser/tokenizer.c#L1047-L1051
Снимок экрана 2021-10-22 в 23 08 09

I am not sure, but it also looks like a private thing, it should not affect other users.

https://bugs.python.org/issue45574

Automerge-Triggered-By: GH:pablogsal

@sobolevn

Copy link Copy Markdown

Member Author

Looks like no warnings are generated 🎉

@pablogsal pablogsal left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for the PR 👌

@miss-islington miss-islington merged commit 4bc5473 into python:main

Oct 22, 2021

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

Copy link Copy Markdown

GH-29176 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10

only security fixes

label

Oct 22, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 22, 2021 
)

It used to be like this:
<img width="1232" alt="Снимок экрана 2021-10-22 в 23 07 40" src="https://user-images.githubusercontent.com/4660275/138516608-fef6ec01-a96a-40f4-81ef-52265b0f536b.png">

Quick `grep` tells that it is just used in one place under `Py_DEBUG`: https://github.com/python/cpython/blame/f6e8b80d20159596cf641305bad3a833bedd2f4f/Parser/tokenizer.cGH-L1047-L1051
<img width="752" alt="Снимок экрана 2021-10-22 в 23 08 09" src="https://user-images.githubusercontent.com/4660275/138516684-ea503136-1e92-48a5-95bb-419e190d5866.png">

I am not sure, but it also looks like a private thing, it should not affect other users.

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 4bc5473)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

pablogsal pushed a commit that referenced this pull request

Oct 23, 2021 
…29176)

It used to be like this:
<img width="1232" alt="Снимок экрана 2021-10-22 в 23 07 40" src="https://user-images.githubusercontent.com/4660275/138516608-fef6ec01-a96a-40f4-81ef-52265b0f536b.png">

Quick `grep` tells that it is just used in one place under `Py_DEBUG`: https://github.com/python/cpython/blame/f6e8b80d20159596cf641305bad3a833bedd2f4f/Parser/tokenizer.cGH-L1047-L1051
<img width="752" alt="Снимок экрана 2021-10-22 в 23 08 09" src="https://user-images.githubusercontent.com/4660275/138516684-ea503136-1e92-48a5-95bb-419e190d5866.png">

I am not sure, but it also looks like a private thing, it should not affect other users.

Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 4bc5473)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni