◐ Shell
clean mode source ↗

bpo-29070: Integration tests for pty module with patch from bpo-26228 by diekmann · Pull Request #2932 · python/cpython

added 25 commits

July 28, 2017 17:13
We need to monkey patch the freshly spawned child! Tested that it is
actually called by writing to stderr (test code commented out, I don't
want to push the verbose flag through all those children).
Awesome idea by Martin Panter!
PtySpawnTestBase (though it does not define any tests) wants to inherit
from unittest to have self.fail() available
We don't capture stdin/stdout by running the child and returning what
was written once the child is done.  We spawn the child and have the
pipes available to communicate with the child while it is running.
* remove unrealted code comment
* tune documentation
* rename function
* remove if verbose
Now that code is closer together, we can move up more into the setUp
methods.
Better terminology, clearly introducing background/slave.
We still have test_eof. And test_bell_echoctl tests echoctl.
"Also, no documentation string for the method should be included. A
comment (such as # Tests function returns only True or False) should be
used to provide documentation for test methods. This is done because
documentation strings get printed out if they exist and thus what test
is being run is not stated." /Doc/build/html/library/test.html
TODO: This branch also includes the patch from Chris Torek bpo-26228.

@diekmann