bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467) by tiran · Pull Request #29467 · python/cpython
🤖 New build scheduled with the buildbot fleet by @tiran for commit 73438e406438b95b299ddc37d4e8867053fbadfc 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
🤖 New build scheduled with the buildbot fleet by @tiran for commit dad6caa04c8a9ed153341a7ad644cb831f0d02ef 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
Signed-off-by: Christian Heimes <christian@python.org>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about configure.ac (I haven't looked at the setup.py changes yet)
Comment on lines +3128 to +3130
| AC_CHECK_LIB([ndbm], [dbm_open]) | ||
| LIBS="$LIBS_SAVE" | ||
| AC_CHECK_LIB([gdbm_compat], [dbm_open]) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can fold these into:
| AC_CHECK_LIB([ndbm], [dbm_open]) | |
| LIBS="$LIBS_SAVE" | |
| AC_CHECK_LIB([gdbm_compat], [dbm_open]) | |
| AC_SEARCH_LIBS([dbm_open], [ndbm gdbm_compat]) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AC_SEARCH_LIBS() does not create HAVE_LIBFOO entries.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's unfortunate.
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is it worth it to document the USE_* defines in whatsnew?
LGTM. Is it worth it to document the
USE_*defines inwhatsnew?
It's an internal detailed of the build system and not user-facing.
bpo-45747: Detect gdbm/dbm dependencies in configure
bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467)
remykarem pushed a commit to remykarem/cpython that referenced this pull request
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
remykarem pushed a commit to remykarem/cpython that referenced this pull request
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
