◐ Shell
clean mode source ↗

gh-89928: consume dev_t with PyLong_FromUnsignedLongLong by AMDmi3 · Pull Request #29494 · python/cpython

the-knights-who-say-ni

Conversation

@AMDmi3

@AMDmi3 AMDmi3 commented

Nov 9, 2021

•

edited by bedevere-app Bot

Loading

@github-actions

This PR is stale because it has been open for 30 days with no activity.

@kumaraditya303

@AMDmi3

@MaxwellDupre

I dont see the following:
#if defined(__FreeBSD__) #define DEVICE_MAJORMINOR_T int #else #define DEVICE_MAJORMINOR_T unsigned int #endif
In your Files changed, please explain?

@AMDmi3

I dont see the following:

Because it's not there, obviously. This PR only addresses one aspect of the problem.

MaxwellDupre

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@erlend-aasland erlend-aasland changed the title bpo-45767: consume dev_t with PyLong_FromUnsignedLongLong gh-89928: consume dev_t with PyLong_FromUnsignedLongLong

Jan 5, 2024

@AMDmi3 AMDmi3 mannequin mentioned this pull request

Mar 28, 2024

@serhiy-storchaka

Thank you for your contribution, but more complex #31794 was merged instead.

Labels