bpo-45873: Restore Python 3.6 compatibility (GH-29730) by tiran · Pull Request #29730 · python/cpython

🤖 New build scheduled with the buildbot fleet by @tiran for commit f5818e6 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

🤖 New build scheduled with the buildbot fleet by @tiran for commit cb24cf5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

LGTM, but is it even worth testing for 3.7+? Why not always take the slow path?

I left the old implementation in because it's more readable. The fast path is now in a doc string for future reference.

I also added more debug code to configure to figure out what is going on on the Debian buildbot.

Closing and reopening to retrigger Azure.

(Why do we even bother with "python3 python"? For weird platforms that have only one of those but it happens to be 3.6 or better?)

I don't know and kept python 3 python just in case.

Broke Azure tests are likely caused by GH-28612.

How? That PR was closed without merging. And if there was a cause outside this PR why would it not have failed before (e.g. when I submitted #29717)?

Are you suggesting there are some cached files from running that PR present?

@tiran: Status check is done, and it's a failure ❌ .