◐ Shell
clean mode source ↗

bpo-45893: Add missing extern C to initconfig.h (GH-29761) by tiran · Pull Request #29761 · python/cpython

Co-authored-by: Steve Dower <steve.dower@python.org>

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Steve's other suggestion?

@tiran

What about Steve's other suggestion?

Thanks for the ping. I missed his suggestion. I'll amend the PR.

@tiran

GHA now has:

  python_uwp.cpp
  Generating code
  Finished generating code
  pythonw_uwp.vcxproj -> D:\a\cpython\cpython\PCbuild\amd64\pythonw_uwp.exe

@tiran tiran changed the title bpo-45893: Add missing extern C to initconfig.h bpo-45893: Add missing extern C to initconfig.h (GH-29761)

Nov 24, 2021

@miss-islington

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 24, 2021
Co-authored-by: Steve Dower <steve.dower@python.org>
(cherry picked from commit f4afc53)

Co-authored-by: Christian Heimes <christian@python.org>

@bedevere-bot

miss-islington added a commit that referenced this pull request

Nov 24, 2021
Co-authored-by: Steve Dower <steve.dower@python.org>
(cherry picked from commit f4afc53)

Co-authored-by: Christian Heimes <christian@python.org>

remykarem pushed a commit to remykarem/cpython that referenced this pull request

Dec 7, 2021
Co-authored-by: Steve Dower <steve.dower@python.org>