◐ Shell
clean mode source ↗

bpo-45582: Fix framework path and bootstrap build by tiran · Pull Request #29954 · python/cpython

tiran

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tiran

@tiran tiran commented

Dec 7, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

  • Check NS API return values for NULL to prevent segfault in
    _bootstrap_python.
  • Set modPathInitialized to 1 so the decode_to_dict path is used.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45582

 
* Check NS API return values for NULL to prevent segfault in
  ``_bootstrap_python``.
* Set modPathInitialized to 1 so the ``decode_to_dict`` path is used.

Signed-off-by: Christian Heimes <christian@python.org>

@tiran tiran force-pushed the bpo-45582-framework branch from ed7337c to 84e68b1 Compare

December 7, 2021 11:01

@tiran tiran marked this pull request as ready for review

December 7, 2021 12:03

@ned-deily ned-deily left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ambv ambv merged commit 06c4ae8 into python:main

Dec 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

@ned-deily ned-deily ned-deily approved these changes

@ambv ambv Awaiting requested review from ambv

@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran @zooba @ned-deily @ambv @the-knights-who-say-ni @bedevere-bot