bpo-45711: Do not push/pop traceback on stack as part of exc_info by iritkatriel · Pull Request #29968 · python/cpython
Marked as draft because I still need to update the opcodes documentation
|
|
||
| assert(exc_info->exc_value); | ||
| if (exc_info->exc_value != Py_None) { | ||
| exc_info->exc_traceback = PyException_GetTraceback(exc_info->exc_value); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next step is to remove exc_traceback from exc_info and then this will not be here.
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 98085fe 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
This clashes with the except* branch, and I'd rather merge that one first and update this one.
This clashes with the except* branch, and I'd rather merge that one first and update this one.
I would rather merge this first.
Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.
This clashes with the except* branch, and I'd rather merge that one first and update this one.
I would rather merge this first. Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.
We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.
We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.
And that requires PR 29922.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing between tokens is strange.