bpo-46005: add note about setuptools to Doc/extending/building.rst by sobolevn · Pull Request #30062 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would remove the news snippet. It will not really provide value when collected in a NEWS document (unless I’ve missed recent conventions, NEWS does not duplicate the full git changelog).
Wasn’t there a python.github.io site configured to show docs built from pull requests?
Wasn’t there a python.github.io site configured to show docs built from pull requests?
The artifact is uploaded here 🙂
BTW, @merwok, should this be backported to 3.9? I think distutils was only deprecated in 3.10.
Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂
I checked the 3.9 branch and the _setuptools_disclaimer.rst is there, so we can backport.
The formal deprecation may be in 3.10, but the package was minimally maintained before and setuptools was recommended.
Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂
I don't know of such a website (but then, I'm fairly new to CPython! If there is one, I'd be very interested to know about it...)
Having downloaded and extracted it myself, this is what it looks like, anyhow!
bpo-46005: add
bpo-46005: add note about setuptools to Doc/extending/building.rstsetuptools note to Doc/extending/building.rst
Thanks for the PR, @sobolevn!
I'm not sold on this change though. I'm marking this PR as "do not merge" for now, until the discussion on the b.p.o. issue reaches a conclusion.
I am closing this PR, because distutils module was completely removed.
There will be major changes to its documentation.