◐ Shell
clean mode source ↗

bpo-46341: remove duplicate paragraphs in asyncio documentation by davem14 · Pull Request #30526 · python/cpython

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@davem14

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

asvetlov

asvetlov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is visible to the end user.
Please create an issue on https://bugs.python.org first.

Otherwise looks good.

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@davem14

I have made the requested changes; please review again

@bedevere-bot

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@AlexWaygood

If you change the title of your PR to "bpo-46341: remove duplicate paragraphs in asyncio documentation", the bots will automatically link this PR to your BPO issue and turn the CI green :)

@davem14 davem14 changed the title remove duplicates bpo-46341: remove duplicate paragraphs in asyncio documentation

Jan 11, 2022

@AlexWaygood

Btw, you've also used the 3.10 branch as the base for this PR — changes to CPython are nearly always made to the main branch (which is currently the development branch for as-yet-unreleased 3.11) first, and then backported to 3.10/3.9 if necessary :)

@davem14

So, what should I do now?

@AlexWaygood

Closing the PR and refiling against the main branch might be the easiest solution, I'm afraid :/ feel free to ping me if you do so, and I'll add the skip-news label to your new PR 🙂 you can obviously link your new PR to the same BPO ticket.

Also, as an aside, it would be great if you could sign the CLA, if you haven't already. It's not necessary for very small/trivial changes, but for legal reasons CPython can't accept significant contributions from people who haven't signed the CLA 🙂