bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552) by tiran · Pull Request #30552 · python/cpython

the-knights-who-say-ni

Conversation

Co-authored-by: Ethan Smith <ethan@ethanhs.me>
Signed-off-by: Christian Heimes <christian@python.org>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.

Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.

It does now :)

tiran marked this pull request as ready for review

January 12, 2022 09:01

tiran mentioned this pull request

Jan 12, 2022

tiran changed the title ~~bpo-40280: Add --with-emscripten-target to build for browser or node~~ bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552)

Jan 12, 2022

tiran deleted the bpo-40280-emscripten-targets branch

January 12, 2022 15:08

This was referenced

Jan 12, 2022