◐ Shell
clean mode source ↗

bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615) by tiran · Pull Request #30615 · python/cpython

the-knights-who-say-ni

Conversation

@tiran

@tiran tiran commented

Jan 15, 2022

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@tiran tiran force-pushed the bpo-40280-test-subprocess branch from e61311a to 87fd2fe Compare

January 16, 2022 22:03

@tiran tiran force-pushed the bpo-40280-test-subprocess branch 2 times, most recently from 61decef to 8c9097e Compare

January 21, 2022 15:38

@tiran tiran force-pushed the bpo-40280-test-subprocess branch from 8c9097e to d20fdb2 Compare

January 24, 2022 08:19

@tiran tiran marked this pull request as ready for review

January 24, 2022 08:52

@emmatyping emmatyping left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@tiran tiran changed the title bpo-40280: Skip subprocess-based tests on wasm32-emscripten bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615)

Jan 25, 2022

@tiran tiran merged commit 8464fbc into python:main

Jan 25, 2022

@tiran tiran deleted the bpo-40280-test-subprocess branch

January 25, 2022 07:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@gpshead gpshead gpshead approved these changes

@emmatyping emmatyping emmatyping approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran @gpshead @emmatyping @kumaraditya303 @the-knights-who-say-ni @bedevere-bot