gh-69093: Support basic incremental I/O to blobs in `sqlite3` by erlend-aasland · Pull Request #30680 · python/cpython

palaviv

BTW, I went over the review comments on the original PR; it seems that the following two comments by Berker are not addressed yet:

I think we should heed those suggestions. If you are ok with that, I'll fix those right away.

proposed patch

commit 69a5a1e2453710a34bfaf7863f94ea9dacefbedf (HEAD -> sqlite-blob-reduced)
Author: Erlend E. Aasland <erlend.aasland@innova.no>
Date:   Fri Apr 15 00:53:09 2022 +0200

    Address Berker's comments from gh-271: move __len__ doc to class description

diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst
index 992256c134..d0274fb797 100644
--- a/Doc/library/sqlite3.rst
+++ b/Doc/library/sqlite3.rst
@@ -1115 +1115,2 @@ Blob Objects
-   data in an SQLite :abbr:`BLOB (Binary Large OBject)`.
+   data in an SQLite :abbr:`BLOB (Binary Large OBject)`.  Call ``len(blob)`` to
+   get the size (number of bytes) of the blob.
@@ -1125,4 +1125,0 @@ Blob Objects
-   .. method:: __len__()
-
-      Return the blob size in bytes.
-

commit 2590112aff8ec625aa5d1debb8fdc10f36fa3017
Author: Erlend E. Aasland <erlend.aasland@innova.no>
Date:   Fri Apr 15 00:52:47 2022 +0200

    Address Berker's comments from gh-271: remove unneeded class prefix

diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst
index 0d4dbdf64d..992256c134 100644
--- a/Doc/library/sqlite3.rst
+++ b/Doc/library/sqlite3.rst
@@ -1117 +1117 @@ Blob Objects
-   .. method:: Blob.close()
+   .. method:: close()
@@ -1125 +1125 @@ Blob Objects
-   .. method:: Blob.__len__()
+   .. method:: __len__()
@@ -1129 +1129 @@ Blob Objects
-   .. method:: Blob.read(length=-1, /)
+   .. method:: read(length=-1, /)
@@ -1137 +1137 @@ Blob Objects
-   .. method:: Blob.write(data, /)
+   .. method:: write(data, /)
@@ -1143 +1143 @@ Blob Objects
-   .. method:: Blob.tell()
+   .. method:: tell()
@@ -1147 +1147 @@ Blob Objects
-   .. method:: Blob.seek(offset, origin=os.SEEK_SET, /)
+   .. method:: seek(offset, origin=os.SEEK_SET, /)