◐ Shell
clean mode source ↗

bpo-46430: Intern strings in deep-frozen modules by kumaraditya303 · Pull Request #30683 · python/cpython

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this isn't going to be enough, alas. :-(

I've tried to drop a few hints in the review. :-)

@kumaraditya303

@gvanrossum

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just think we shouldn't ignore errors.

methane

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fair enough.

@vstinner