bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ by tiran · Pull Request #30851 · python/cpython
🤖 New build scheduled with the buildbot fleet by @tiran for commit ebd654724c6e3d0b528f1313b7654002eef40b52 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
Test build without AC_C_CHAR_UNSIGNED
bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
| /* This module currently does not work on systems where only unsigned | ||
| characters are available. Take it out of Setup. Sorry. */ |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last part of the comment should be removed, it is confusing without the preprocessor guards. I'd consider just dropping the comment, a compiler where "signed char" is not signed should be considered broken.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment was introduced by b6775db in 1994, just five years after the first ever C standard was published. Internet distribution was slow and software companies were rigid back then so no surprise compatibility with per vendor compiler quirks was a real deal.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this outdated comment. audioop explicitly uses signed char and unsigned char. Maybe to avoid any risk of confusion, the C code should use int8_t and uint8_t.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is pining for the fjords.
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
Sorry, @tiran, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6e5a193816e1bdf11f5fb78d620995fd6987ccf8 3.10
Sorry @tiran, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6e5a193816e1bdf11f5fb78d620995fd6987ccf8 3.9
tiran added a commit to tiran/cpython that referenced this pull request
…onGH-30851) (cherry picked from commit 6e5a193) Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit to tiran/cpython that referenced this pull request
…nGH-30851) (cherry picked from commit 6e5a193) Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit that referenced this pull request
tiran added a commit that referenced this pull request
) (GH-30915) Co-authored-by: Christian Heimes <christian@python.org>
