◐ Shell
clean mode source ↗

bpo-40280: Use presence of msvcrt module to detect Windows by tiran · Pull Request #30930 · python/cpython

tiran

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tiran

@tiran tiran commented

Jan 26, 2022

•

edited by miss-islington

Loading

Copy link Copy Markdown

Member

https://bugs.python.org/issue40280

Automerge-Triggered-By: GH:tiran

@zware zware left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware

zware commented

Jan 26, 2022

Copy link Copy Markdown

Member

The NEWS entry from GH-30620 will need some rewording.
gpshead and tiran reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@zware zware zware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran @zware @gpshead @the-knights-who-say-ni @bedevere-bot @miss-islington