◐ Shell
clean mode source ↗

bpo-46541: Generate the global objects initializer. by ericsnowcurrently · Pull Request #30941 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented

Jan 27, 2022

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

This change is a prerequisite for generating code for other global objects (like strings in gh-30928).

(I borrowed some code from Tools/scripts/deepfreeze.py.)

https://bugs.python.org/issue46541

olife-png reacted with thumbs up emoji olife-png reacted with hooray emoji

@pxeger

pxeger commented

Jan 27, 2022

Copy link Copy Markdown

Contributor

This should probably be documented in the devguide

olife-png reacted with thumbs up emoji olife-png reacted with hooray emoji

@ericsnowcurrently

ericsnowcurrently commented

Jan 27, 2022

edited

Loading

Copy link Copy Markdown

Member Author

This should probably be documented in the devguide

Yeah, we should definitely add some documentation there about the various code generation tools we use:

  • argument clinic
  • blurb
  • freeze_modules.py
  • deepfreeze.py
  • ...

Consider opening a BPO issue so this doesn't get lost. Feel free to nosy me.

olife-png reacted with thumbs up emoji olife-png reacted with hooray emoji

@pxeger

pxeger commented

Jan 27, 2022

Copy link Copy Markdown

Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently @pxeger @the-knights-who-say-ni @bedevere-bot