◐ Shell
clean mode source ↗

bpo-46556: emit `DeprecationWarning` from `pathlib.Path.__enter__()` by barneygale · Pull Request #30971 · python/cpython

the-knights-who-say-ni

In Python 3.9 / bpo-39682 we made `Path.__exit__()` a no-op, and added a
comment in the code mentioning that it should be deprecated in future. The
future is here, so let's deprecate it.

sobolevn

tirkarthi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are deprecation warnings emitted by other tests too :

./python -Wall -m test test_pathlib         
0:00:00 load avg: 0.37 Run tests sequentially
0:00:00 load avg: 0.37 [1/1] test_pathlib
/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1833: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.
  with p:
/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1842: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.
  with p:
/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1833: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.
  with p:
/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1842: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.
  with p:

== Tests result: SUCCESS ==

1 test OK.

Total duration: 586 ms
Tests result: SUCCESS

brettcannon

brettcannon

@brettcannon

I'm ready to merge this, but there was a CI hiccup; just trying to work passed that.

@miss-islington

@barneygale: Status check is done, and it's a failure ❌ .

@miss-islington

@barneygale: Status check is done, and it's a failure ❌ .

@brettcannon