◐ Shell
clean mode source ↗

[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) by erlend-aasland · Pull Request #31030 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

Erlend Egeberg Aasland added 2 commits

January 26, 2022 22:23
(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
pythonGH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.

@erlend-aasland

GH-27613 (bpo 44839) was not backported, so exceptions differ between main and older versions. See 28de39f.

JelleZijlstra

@JelleZijlstra

@gvanrossum I'm planning to merge this (a backport of #27642 which you previously merged after my review). The only non-test changes fix a missed error check for PyFloat_AsDouble, so this should be fine in the bugfix branches.

@gvanrossum

+1. If adding tests never caused us to fix any bugs we’d be doing it wrong. :-)

@miss-islington

@miss-islington

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ba457fe6f8e50ad3ef3ceffb75dee96629a42ad7 3.9

@erlend-aasland

Thanks; I'll fix the 3.9 backport.

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request

Feb 25, 2022

@bedevere-bot

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request

Jun 2, 2022

Labels