◐ Shell
clean mode source ↗

bpo-40280: Address more test failures on Emscripten (GH-31050) by tiran · Pull Request #31050 · python/cpython

@tiran

Fix wasm32-emscripten test failures and platform issues.

  • Disable syscalls that are not supported or don't work, e.g.
    wait, getrusage, prlimit, mkfifo, mknod, setres[gu]id, setgroups.
  • Use fd_count to cound open fds.
  • Add more checks for subprocess and fork.
  • Add workarounds for missing _multiprocessing and failing socket.accept()
  • Enable bzip2 again
  • Disable large file support
  • Disable signal.alarm for now

https://bugs.python.org/issue40280

@tiran tiran marked this pull request as ready for review

February 1, 2022 14:14

brettcannon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are about recording the known bugs in emscripten and musl so we can easily track when they are fixed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bugs?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bug?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added links to bpo and emscripten bug tracker.

Co-authored-by: Brett Cannon <brett@python.org>

@tiran

@tiran

The failing Windows test is covered by GH-31146

@tiran tiran changed the title bpo-40280: Address more test failures on Emscripten bpo-40280: Address more test failures on Emscripten (GH-31050)

Feb 5, 2022

@tiran tiran deleted the bpo-40280-more-test-fixes branch

February 5, 2022 19:52