[3.8] bpo-46648: Skip test_urllib2.test_issue16464() (GH-31161) by miss-islington · Pull Request #31173 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Contributor
POST requests to http://www.example.com/ fail randomly.
(cherry picked from commit 1578de2)
Co-authored-by: Victor Stinner vstinner@python.org
POST requests to http://www.example.com/ fail randomly. (cherry picked from commit 1578de2) Co-authored-by: Victor Stinner <vstinner@python.org>
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
mentioned this pull request
miss-islington
commented
Feb 6, 2022
miss-islington commented
Contributor Author
@vstinner: Status check is done, and it's a success ✅ .
bedevere-bot
added
the
awaiting review
label
vstinner
commented
Feb 6, 2022
vstinner commented
Member
@ambv: You may want to get this fix. The 10 Refleaks 3.8 buildbots are failing because of test_urllib2: https://buildbot.python.org/all/#/release_status
miss-islington
commented
Feb 6, 2022
miss-islington commented
Contributor Author
@vstinner: Status check is done, and it's a success ✅ .
gpshead
commented
Feb 7, 2022
gpshead commented
Member
fwiw, a more proper fix to backport is coming in #31186. but it probably doesn't matter which one is chosen for 3.8 as it's not like the code this is testing behavior of could ever change in this branch.
ambv
mentioned this pull request
ambv
merged commit
f87e616
into
python:3.8
bedevere-bot
removed
the
awaiting review
label
miss-islington
deleted the
backport-1578de2-3.8
branch
vstinner
commented
Feb 8, 2022
vstinner commented
Member
Thanks for the merge @ambv!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment