◐ Shell
clean mode source ↗

[3.8] bpo-46648: Skip test_urllib2.test_issue16464() (GH-31161) by miss-islington · Pull Request #31173 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Feb 6, 2022

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

POST requests to http://www.example.com/ fail randomly.
(cherry picked from commit 1578de2)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue46648

POST requests to http://www.example.com/ fail randomly.
(cherry picked from commit 1578de2)

Co-authored-by: Victor Stinner <vstinner@python.org>

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@vstinner

vstinner commented

Feb 6, 2022

Copy link Copy Markdown

Member

@ambv: You may want to get this fix. The 10 Refleaks 3.8 buildbots are failing because of test_urllib2: https://buildbot.python.org/all/#/release_status

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@gpshead

gpshead commented

Feb 7, 2022

Copy link Copy Markdown

Member

fwiw, a more proper fix to backport is coming in #31186. but it probably doesn't matter which one is chosen for 3.8 as it's not like the code this is testing behavior of could ever change in this branch.

@ambv ambv merged commit f87e616 into python:3.8

Feb 8, 2022

@miss-islington miss-islington deleted the backport-1578de2-3.8 branch

February 8, 2022 09:52

@vstinner

vstinner commented

Feb 8, 2022

Copy link Copy Markdown

Member

Thanks for the merge @ambv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @vstinner @gpshead @ambv @the-knights-who-say-ni @bedevere-bot