◐ Shell
clean mode source ↗

[3.9] bpo-46648: Rewrite test_urllib2.test_issue16464() with a local HTTP server (GH-31186) by miss-islington · Pull Request #31190 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Feb 7, 2022

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet
and use the local HTTP server rather than an external HTTP server.
(cherry picked from commit 8e98175)

Co-authored-by: Nikita Sobolev mail@sobolevn.me

https://bugs.python.org/issue46648

 
…erver (pythonGH-31186)

Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet
and use the local HTTP server rather than an external HTTP server.
(cherry picked from commit 8e98175)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

@miss-islington

Copy link Copy Markdown

Contributor Author

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .

2 similar comments

@miss-islington

Copy link Copy Markdown

Contributor Author

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Copy link Copy Markdown

Contributor Author

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link Copy Markdown

Contributor Author

Sorry, I can't merge this PR. Reason: 2 of 5 required status checks are expected..

@miss-islington

Copy link Copy Markdown

Contributor Author

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 0d74efc into python:3.9

Feb 7, 2022

@miss-islington miss-islington deleted the backport-8e98175-3.9 branch

February 7, 2022 13:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @sobolevn