bpo-46711: increase timeout for `test_logging::test_post_fork_child_no_deadlock` by sobolevn · Pull Request #31274 · python/cpython
I think it might have some consequences 🤔
Right now SHORT_TIMEOUT is just 30 seconds, while LONG_TIMEOUT is 5 minutes.
It is a 10x increase.
Secondly, current docs state (https://docs.python.org/3/library/test.html#test.support.SHORT_TIMEOUT):
If a test using SHORT_TIMEOUT starts to fail randomly on slow buildbots, use LONG_TIMEOUT instead.
Initially I've followed this recommendation.
Do we have other tests that fail due to this timeout? Is it a global problem? You totally have more data than me on this problem.
Lastly, regrtest has --timeout, which we can change for slower runners.
If you think that we still should change the default, I have several questions:
- I guess we need to add
.. versionchanged:: 3.11towait_processdocs and change the default value there - In this case we would have to recommend using
SHORT_TIMEOUTif users expect some test to be fast, am I right? Or should we just remove this from the docs completely? - Should we change
--timeout=flags that are used in the project somehow? https://cs.github.com/python/cpython?q=--timeout%3D