◐ Shell
clean mode source ↗

bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules by corona10 · Pull Request #31358 · python/cpython

erlend-aasland

@erlend-aasland

You need to regenerate global objects. Either run Tools/scripts/generate_global_objects.py, or do make regen-global-objects (I prefer the former as I build out of tree).

Sorry, close is already there :)

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as far as I can see. Let's wait and hear what Eric says.

@ericsnowcurrently

@ericsnowcurrently

Also, thanks for working on this! 🙂

@corona10 corona10 changed the title bpo-46541: Replace _Py_IDENTIFIER with _Py_ID in dbms modules bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules

Feb 16, 2022

@corona10

erlend-aasland

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!