◐ Shell
clean mode source ↗

bpo-46541: Remove usage of _Py_IDENTIFIER from pyexpat by corona10 · Pull Request #31468 · python/cpython

corona10

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@corona10

@corona10 corona10 commented

Feb 21, 2022

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@erlend-aasland

Copy link Copy Markdown

Contributor

Please also remove #define NEEDS_PY_IDENTIFIER

@corona10

Copy link Copy Markdown

Member Author

@erlend-aasland
Ah thanks nice catch :)
erlend-aasland reacted with laugh emoji

@erlend-aasland erlend-aasland left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10 @erlend-aasland @the-knights-who-say-ni @bedevere-bot