bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec by corona10 · Pull Request #31475 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
In the issue number, 65 was transposed as 56. Fixed.
bpo-45641: Remove usage of _Py_IDENTIFIER from multibytecodec
bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
I have made the requested changes; please review again
Thanks for making the requested changes!
@tiran: please review the changes made to this pull request.
After some discussion, I decided to merge this PR anyway.
I will accept the other approach if someone wants :) I hope that this approach would help to reduce the usage of private APIs
cc @ericsnowcurrently, @erlend-aasland, @tiran, @vstinner (alphabetical order :)
