bpo-45138: Fix regression in GH-28240 by erlend-aasland · Pull Request #31783 · python/cpython
Erlend E. Aasland added 5 commits
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I can merge it once we're both happy with it (cc @gvanrossum).
We should also test with buildbots though.
We should also test with buildbots though.
I tried adding the buildbot label via the GH app, but for some reason it does not work. Feel free to send it to the bots now.
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 0ab2575 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
IIUC the buildbots are still red. Maybe it's time to roll back the original commit? Then you can fix it without so much stress.
IIUC the buildbots are still red. Maybe it's time to roll back the original commit? Then you can fix it without so much stress.
Yep, there are some red ones left; I think we should revert now, especially given Łukasz' recent plea about keeping the bots green. I'll close this and submit a new PR in a couple of days.
Thanks, yes I was also going to suggest reverting.