◐ Shell
clean mode source ↗

bpo-45150: Add hashlib.file_digest() for efficient file hashing by tiran · Pull Request #31930 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tiran

@tiran tiran commented

Mar 16, 2022

edited by miss-islington

Loading

Copy link Copy Markdown

Member

https://bugs.python.org/issue45150

Automerge-Triggered-By: GH:tiran

Techcable reacted with thumbs up emoji

@tiran tiran force-pushed the bpo-45150-file-digest branch from 9b218da to 71f0401 Compare

March 16, 2022 12:38

@tiran tiran requested a review from gpshead

March 16, 2022 14:37

@gpshead gpshead left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you implemented this in pure Python.

Comment thread

Lib/hashlib.py Outdated

Comment thread

Lib/hashlib.py Outdated

Comment thread

Lib/test/test_hashlib.py

Comment thread

Doc/library/hashlib.rst Outdated

@bedevere-bot

Copy link Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gpshead gpshead added the type-feature

A feature request or enhancement

label

Mar 21, 2022

@tiran tiran requested a review from gpshead

March 22, 2022 07:45

@miss-islington miss-islington merged commit 4f97d64 into python:main

Mar 22, 2022

@markshannon

Copy link Copy Markdown

Member

This may have broken the buildbots.
https://buildbot.python.org/all/#/builders/713/builds/452

@tiran

tiran commented

Mar 22, 2022

Copy link Copy Markdown

Member Author

This may have broken the buildbots. buildbot.python.org/all/#/builders/713/builds/452

FIPS ... let's see if GH-32046 solves the issue.

@tiran tiran deleted the bpo-45150-file-digest branch

March 22, 2022 13:24

musashay23

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

+1 more reviewer

@musashay23 musashay23 musashay23 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tiran @bedevere-bot @markshannon @gpshead @musashay23 @the-knights-who-say-ni @miss-islington