bpo-47196: Fix function pointer cast in test_imp by hoodmane · Pull Request #32244 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Conversation
The function PyInit_imp_dummy is declared as void f(PyObject* spec)
but called as void f(void). On wasm targets without the call
trampolines this causes a fatal error.
https://bugs.python.org/issue47196
Automerge-Triggered-By: GH:tiran
The function PyInit_imp_dummy is declared as void f(PyObject* spec) but called as void f(void). On wasm targets without the call trampolines this causes a fatal error.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me. All other modules have an init function without an argument (grep -R -A1 PyMODINIT_FUNC Modules/).
@hoodmane: Status check is done, and it's a success ✅ .
miss-islington pushed a commit that referenced this pull request
I missed one PyInit function in #32244. Automerge-Triggered-By: GH:tiran
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters