◐ Shell
clean mode source ↗

bpo-30781: IDLE: Fix help button on configdialog by csabella · Pull Request #3238 · python/cpython

the-knights-who-say-ni

Conversation

terryjreedy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem fixed: help works for all 5 tabs.

@terryjreedy

I approved this without a new test because adding automated testing for the buttons is already part of bpo-30780 and because I want this fixed now ;-).

@miss-islington

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 11, 2017 
This fixes an omission in the ttk conversion patch for this issue, hence no new news.
Patch by Cheryl Sabella.
(cherry picked from commit 3866d9b)

@bedevere-bot

terryjreedy pushed a commit that referenced this pull request

Sep 11, 2017 
This fixes an omission in the ttk conversion patch for this issue, hence no new news.
Patch by Cheryl Sabella.
(cherry picked from commit 3866d9b)

Labels