bpo-30940: specify what happens if ndigits is None or omitted by elenaoat · Pull Request #3256 · python/cpython
elena added 2 commits
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
|
|
||
| For a general Python object ``number``, ``round(number, ndigits)`` delegates to | ||
| ``number.__round__(ndigits)``. | ||
| For a general Python object ``number``, ``round`` delegates to |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than lose information with this edit, I would prefer to make it more precise, "For a general Python object, round(number) or round(number, None) delegates to number.__round__(), and round(number, ndigits) delegates to number.__round__(ndigits)."
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified the text accordingly.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
elena added 2 commits
