◐ Shell
clean mode source ↗

pytime: include winsock2, so we can have a complete timeval type by benjaminp · Pull Request #3377 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@benjaminp

Copy link Copy Markdown

Contributor

No description provided.

Comment thread

Python/pytime.c Outdated

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to add a comment to explain why we need to import networking functions in pytime.c? :-) (To get the timeval structure)

@benjaminp benjaminp merged commit 8338606 into master

Sep 6, 2017

@benjaminp benjaminp deleted the benjamin-winsock2 branch

September 6, 2017 03:45

ericsnowcurrently added a commit that referenced this pull request

Sep 6, 2017

pitrou added a commit to pitrou/cpython that referenced this pull request

Sep 6, 2017

pitrou added a commit to pitrou/cpython that referenced this pull request

Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminp @vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot