◐ Shell
clean mode source ↗

bpo-30860: Consolidate stateful runtime globals. by ericsnowcurrently · Pull Request #3397 · python/cpython

ericsnowcurrently

Conversation

@ericsnowcurrently

(trying again; see #2594)

  • group the (stateful) runtime globals into various topical structs
  • consolidate the topical structs under a single top-level _PyRuntimeState struct
  • add a check-c-globals.py script that helps identify runtime globals

Other globals are excluded (see globals.txt and check-c-globals.py).

https://bugs.python.org/issue30860

benjaminp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the stable API, no?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( I'm going to revert the _Py_CheckRecursionLimit part of the change for now and circle back after this patch lands.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sorts of includes should probably be quoted and qualified "internal/ceval.h".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty initializers aren't standard. You should probably just memset it to 0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on empty initializer list

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ncoghlan

ma8ma added a commit to ma8ma/cpython that referenced this pull request

Sep 9, 2017 
Resolve conflicts:
2ebc5ce bpo-30860: Consolidate stateful runtime globals. (python#3397)

ericsnowcurrently added a commit that referenced this pull request

Sep 12, 2017 
PR #3397 introduced a large number of warnings to the Windows build. This patch fixes them.