◐ Shell
clean mode source ↗

bpo-30860: Move windows.h include out of internal/*.h. by ericsnowcurrently · Pull Request #3458 · python/cpython

ericsnowcurrently

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented

Sep 8, 2017

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

PR #3397 introduced a large number of warnings to the Windows build. This patch fixes them.

https://bugs.python.org/issue30860

@ericsnowcurrently

Copy link Copy Markdown

Member Author

I'm guessing that the following line in PCbuild/pyproject.props is causing the trouble:

<_PydPreprocessorDefinition Condition="$(TargetExt) == '.pyd'">Py_BUILD_CORE_MODULE;</_PydPreprocessorDefinition>

I'll try a related workaround and see if that resolves the current issue.

@ericsnowcurrently

Copy link Copy Markdown

Member Author

Yep, looks like that was it! \o/

@ericsnowcurrently ericsnowcurrently merged commit fc1bf87 into python:master

Sep 12, 2017

@ericsnowcurrently ericsnowcurrently deleted the fix-windows-warnings branch

September 12, 2017 01:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently @Mariatta @the-knights-who-say-ni @bedevere-bot