◐ Shell
clean mode source ↗

[3.6] bpo-31234: Fix dangling thread in test_ftp/poplib by vstinner · Pull Request #3554 · python/cpython

vstinner

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 2 commits into

python:3.6from

vstinner:test_ftplib36

Sep 13, 2017

Merged

[3.6] bpo-31234: Fix dangling thread in test_ftp/poplib#3554

vstinner

merged 2 commits into

python:3.6from

vstinner:test_ftplib36

Conversation

@vstinner

@vstinner vstinner commented

Sep 13, 2017

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member 

Explicitly clear the server attribute in test_ftplib and test_poplib
to prevent dangling thread.

(cherry picked from commit d403a29)
Clear also self.server_thread attribute in TestTimeouts.tearDown().

(cherry picked from commit b157ce1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot