bpo-31715 Add mimetype for extension .mjs by bmeck · Pull Request #3908 · python/cpython

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

The CLA has now been signed, is there anything blocking this?

Needs review from @python/email-team and news entry.

@MylesBorins The news entry lgtm. If @bmeck ended up accepting your PR, then you should sign Python's CLA too.

And we'll need to make sure to add Co-authored by: in the commit message of this PR. (The committer will do this).

thanks @Mariatta I've privately communicated with @bmeck to coordinate... signed the CLA... and look forward to the review.

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

CLA is confirmed if you want to re-run commit bot

I'll leave the argument to someone more familiar with RFC details on mimetypes (there are 3+ RFCs on this), but I think we should maintain consistency between our support of .js and .mjs files.

Currently, .js files are application/javascript, but this proposes to add .mjs as text/javascript, which is seemingly obsolete for modern browsers.

@MylesBorins or @bmeck, do you see a reason to support text/javascript instead of application/javascript?

Sounds good, I'd make the argument that both should use text/javascript then. I'll keep an eye on this if you don't get a response from the email team code owners soon.

I have made the requested changes; please review again.

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!