◐ Shell
clean mode source ↗

bpo-29703: asyncio: Fix creating new event loops in child processes. by 1st1 · Pull Request #404 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

1st1

merged 2 commits into

Mar 3, 2017

Conversation

@mention-bot

@1st1

@tiran

Minor nit pick: The title is slightly confusing. To me a subprocess implies fork+exec. The fix is about fork, so 'child process' or 'forked child' is more descriptive.

@1st1

@tiran It's not only about explicitly forked (with os.fork()) child processes, it's also about subprocesses created with multiprocessing, or even concurrent.futures.ProcessPoolExecutor. All in all I agree you wording is better, will update the commit/news message.

@1st1 1st1 changed the title bpo-29703: asyncio: Fix creating new event loops in subprocesses. bpo-29703: asyncio: Fix creating new event loops in child processes.

Mar 2, 2017

@1st1

@tiran @Haypo Could you please approve this PR? This needs to go in 3.6.1 tomorrow.

@1st1 1st1 mentioned this pull request

Mar 3, 2017

1st1 added a commit to 1st1/cpython that referenced this pull request

Mar 3, 2017

@1st1 1st1 mentioned this pull request

Mar 3, 2017

1st1 added a commit to 1st1/cpython that referenced this pull request

Mar 3, 2017

1st1 added a commit that referenced this pull request

Mar 3, 2017

@1st1

1st1 referenced this pull request

Mar 3, 2017