bpo-29271: Fix Task.current_task and Task.all_tasks to accept None. by 1st1 · Pull Request #406 · python/cpython
| - Issue #24142: Reading a corrupt config file left configparser in an | ||
| invalid state. Original patch by Florian Höch. | ||
|
|
||
| - Issue #29271: Fix Task.current_task and Task.all_tasks to accept |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the entry to the start of the section. Mention that this fixes C implementation, makes it conforming to Python implementation.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we usually appending news items instead of prepending?
| # See http://bugs.python.org/issue29271 for details: | ||
| asyncio.set_event_loop(loop) | ||
| try: | ||
| self.assertTrue(Task.current_task(None) is task) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use assertIs()?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch