◐ Shell
clean mode source ↗

bpo-31926: fix missing *_METHODDEF statements by argument clinic by taleinat · Pull Request #4230 · python/cpython

When a single .c file contains several functions and/or methods with
the same name, a safety _METHODDEF #define statement is generated
only for one of them.

This fixes the bug by using the full name of the function to avoid
duplicates rather than just the name.

serhiy-storchaka

* add news entry
* run "make clinic"
* remove two #ifdef checks in zlibmodule.c which are no longer needed

serhiy-storchaka

@taleinat

serhiy-storchaka

taleinat added a commit to taleinat/cpython that referenced this pull request

Nov 3, 2017
pythonGH-4230)

When a single .c file contains several functions and/or methods with
the same name, a safety _METHODDEF GH-define statement is generated
only for one of them.

This fixes the bug by using the full name of the function to avoid
duplicates rather than just the name..
(cherry picked from commit 4f57409)

vstinner pushed a commit that referenced this pull request

Nov 3, 2017
GH-4230) (#4253)

When a single .c file contains several functions and/or methods with
the same name, a safety _METHODDEF GH-define statement is generated
only for one of them.

This fixes the bug by using the full name of the function to avoid
duplicates rather than just the name..
(cherry picked from commit 4f57409)

embray pushed a commit to embray/cpython that referenced this pull request

Nov 9, 2017
…hon#4230)

When a single .c file contains several functions and/or methods with
the same name, a safety _METHODDEF #define statement is generated
only for one of them.

This fixes the bug by using the full name of the function to avoid
duplicates rather than just the name.

@taleinat taleinat deleted the bpo-31926_clinic_missing_methoddefs branch

June 25, 2018 10:51