bpo-28762: Revert last commit (now using Android Unified Headers) by xdegaye · Pull Request #4488 · python/cpython
Conversation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart the NEWS change.
| .. section: Build | ||
|
|
||
| lockf() is available on Android API level 24, but the F_LOCK macro is not | ||
| defined in android-ndk-r13. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Python 3.7a1 has been released, I dislike the idea of modying the changelog. Please leave it as it is. Add a new NEWS entry if you want to document the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters