◐ Shell
clean mode source ↗

bpo-29040: Support building Android with Unified Headers by xdegaye · Pull Request #4492 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

xdegaye

merged 2 commits into

Nov 23, 2017

Conversation

The first NDK release to support Unified Headers is android-ndk-r14.

yan12125


#ifdef __ANDROID__
#include <android/api-level.h>
/* nl_langinfo() is declared as __INTRODUCED_IN_FUTURE in langinfo.h. */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be better as:

In NDK r14 nl_langinfo() is declared as __INTRODUCED_IN_FUTURE in langinfo.h.

As a side note, since NDK r15, nl_langinfo() is declared as __INTRODUCED_IN(26).

yan12125 pushed a commit to yan12125/python3-android that referenced this pull request

Nov 24, 2017
xdegaye fixes the same problem with a simpler approach [1]. Not sure if
that will break applications on API 26 or not (Android O, Oreo)

[1] python/cpython#4492